Changes consolidation PR #2 #39
Conversation
openshift-ci-robot
added
the
size/L
Signed-off-by: Monis Khan <mkhan@redhat.com>
This allows configuring the log level of the integrated OAuth server via the operator config. We now track the operator config's resource version in the deployment hash. This along with including the hash in the deployment's metadata guarantees that we rollout correctly when the operator's config changes. We still do not rollout in all cases due to the resource syncer. Once we correctly track those config maps and secrets, we should be good. We may end up rolling out "too often," but we can target the hash more closely in the future if that happens. Signed-off-by: Monis Khan <mkhan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stlaz
force-pushed
the
enj_consolidate
branch
from
3053e79 to
28a8668
Compare
|
@stlaz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merged already with #34, closing |
4 participants
Let's just create a whole new PR since the other PRs seem to be failing differently just to see what happens. Nothing to lose at this point.